Skip to content

Add support for multiple key bags, incl. rework of test files#65

Open
nitram509 wants to merge 9 commits into
SSLMate:masterfrom
nitram509:feature-multiple-key-bags
Open

Add support for multiple key bags, incl. rework of test files#65
nitram509 wants to merge 9 commits into
SSLMate:masterfrom
nitram509:feature-multiple-key-bags

Conversation

@nitram509

@nitram509 nitram509 commented Oct 30, 2024 •
edited
Loading

Copy link
Copy Markdown

This PR supersedes
#63 "Implement DecodeChains function that accepts multiple key bags"
and #64 "refactor tests to use static files, to ease development"
Resolves #62

It contains three main changes/enhancements

  • new function DecodeChains() supports decoding multiple safebags with private keys
  • refactored tests to use embed feature of go to ease test file creation and usage
  • splitting source files to separate pfx encoder and decoder logic, makes code more readable
  • fixes a bug in Implement DecodeChains function that accepts multiple key bags #63, when CA certificate chains contained duplicate certificates
  • improved documentation for users, to better guide, when to use what function (e.g. DecodeChain vs. DecodeTruststore)

Any feedback welcome.

This was referenced Oct 30, 2024
Closed
Open
@nitram509

nitram509 commented Dec 21, 2024

Copy link
Copy Markdown
Author

Hi @AGWA may I ask for a review, please?

@marsskop

marsskop commented Feb 7, 2025

Copy link
Copy Markdown

Tests pass now:

$ go test                                                          
PASS
ok      software.sslmate.com/src/go-pkcs12      0.842s

@nitram509

nitram509 commented Mar 3, 2025

Copy link
Copy Markdown
Author

Hi @AGWA , @tony2001 , @aramase may I ask, if you could review this PR, please - or ow can I support further?

@nitram509 nitram509 mentioned this pull request May 20, 2025
Draft
21 tasks
@nitram509

nitram509 commented May 20, 2025

Copy link
Copy Markdown
Author

Hi @AGWA , @tony2001 , @aramase may I ask, if you could review this PR, please - or ow can I support further?

Hi @AGWA, may I ask if there's a chance you could have some time to review, merge and release this PR, please?

@ggpslop

ggpslop commented Jun 11, 2026

Copy link
Copy Markdown

@nitram509 @ThomasHEaton @marsskop
Hi, I forked this repository to implement a flexible Builder to create customized PKCS12s. I will keep my fork updated to this, but extend it with features that will never be implemented here.
My fork: https://github.com/ggpslop/go-pkcs12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement DecodeChains function that accepts multiple key bags

3 participants

@nitram509 @marsskop @ggpslop